sh icon indicating copy to clipboard operation
sh copied to clipboard

cmd/shfmt: prefix editorconfig properties

Open sdavids opened this issue 1 year ago • 5 comments

You should prefix the .editorconfig properties defined by shfmt.

Similar to what JetBrains does:

Editorconfig

Generic IntelliJ options that have the ij_ prefix and are applicable to all languages

Otherwise different tools might interpret the same key differently defeating the whole purpose of using .editorconfig in the first place.

sdavids avatar Sep 20 '24 09:09 sdavids

Is this something that editorconfig themselves recommend? I don't oppose the idea, but I'd also prefer to stick to the upstream recommendations.

mvdan avatar Sep 20 '24 09:09 mvdan

https://github.com/editorconfig/editorconfig/issues/516

sdavids avatar Sep 20 '24 10:09 sdavids

OK thanks. I will follow that thread for now.

mvdan avatar Sep 20 '24 10:09 mvdan

https://github.com/editorconfig/editorconfig/issues/332

sdavids avatar Jan 13 '25 14:01 sdavids

Thanks for linking to that new thread. It seems like there still isn't a consensus for me to follow.

mvdan avatar Jan 13 '25 15:01 mvdan