Daniel Martí

Results 1558 comments of Daniel Martí

Because you're using flag.StringVar rather than flag.Var; that takes Value, which is where IsBoolFlag may be present. If you get stuck it's not a problem, I'll get to it at...

That's already the case with all boolean flags in Go: ``` $ shfmt --space-redirects

Share the same type. FWIW a single string value is still enough as long as you set the default to `"false"` - then the only allowed defaults can be `"false"`,...

Is this something that editorconfig themselves recommend? I don't oppose the idea, but I'd also prefer to stick to the upstream recommendations.

OK thanks. I will follow that thread for now.

Thanks for linking to that new thread. It seems like there still isn't a consensus for me to follow.

There should be parameters that this code action doesn't move to a struct, such as those with types `context.Context`, `*testing.T`, or `testing.TB`. To play it safe, one might want to...

We'll add the new APIs and the `cue fix` in the upcoming release. We can remove support for the old behavior at a later point in time.

Per Marcel, add an API in the strings package called Bytes to convert a string to a byte slice.

Adding this seems fine, but don't hide it behind a flag. If the number of replacements growing too large is a problem, we just need a better algorithm for them,...