react-div-100vh icon indicating copy to clipboard operation
react-div-100vh copied to clipboard

This doesn't work with gatsby?

Open mhedengren opened this issue 4 years ago • 4 comments

Somehow I cannot get this to work with gatsby, the safari toolbar in iOS is still covering the div. I'm using the FullHeightComponent on my index page within the Layout compontent.

repo: https://github.com/mhedengren/just-a-test

netlify for checkout on phone https://objective-kowalevski-bd15a4.netlify.app/

Am I doing something wrong?

mhedengren avatar Sep 05 '20 12:09 mhedengren

Hi Melker,

thanks for reporting and for the nice reproduction. Will look into it tomorrow.

mvasin avatar Sep 06 '20 20:09 mvasin

I spotted a problem with SSR and tried to so solve it - my attempt is already on master and published as [email protected]. It seems to work in iOS Chrome, but seems not to work in iOS Safari (I'm on iOS version 13.6.1).

The idea came from https://joshwcomeau.com/react/the-perils-of-rehydration/, but I suspect that some non-gatsby but SSRed apps may re-render unpredictable amount of times before getting flushing SSRed HTML to the client, so the proposed solution to render in two passes may not suit all.

@mhedengren I'm still exploring this issue and will keep you updated.

mvasin avatar Sep 07 '20 23:09 mvasin

I spotted a problem with SSR and tried to so solve it - my attempt is already on master and published as [email protected]. It seems to work in iOS Chrome, but seems not to work in iOS Safari (I'm on iOS version 13.6.1).

The idea came from https://joshwcomeau.com/react/the-perils-of-rehydration/, but I suspect that some non-gatsby but SSRed apps may re-render unpredictable amount of times before getting flushing SSRed HTML to the client, so the proposed solution to render in two passes may not suit all.

@mhedengren I'm still exploring this issue and will keep you updated.

Ok I see! Sounds great :) Many thanks for taking your time do to this.

mhedengren avatar Sep 08 '20 10:09 mhedengren

Hi @mhedengren! If you're still using the component, can you try out [email protected]? The API might have changed, please consult the readme.

mvasin avatar Nov 07 '21 21:11 mvasin