rustic icon indicating copy to clipboard operation
rustic copied to clipboard

Killer move value error?

Open Lucas-dominguez opened this issue 2 years ago • 1 comments

Hello, Here https://github.com/mvanthoor/rustic/blob/17b15a34b68000dffb681277c3ef6fc98f935a0b/src/search/sorting.rs#L67 it should be value = MVV_LVA_OFFSET - ((n as u32 + 1) * KILLER_VALUE); because n is the index of the while loop.

Because as it is the killer value will depend on the order of global moves and not on the order of killersmoves as you said in the blog.

But maybe it's not a problem.

Have a nice day.

Lucas-dominguez avatar Jul 28 '23 10:07 Lucas-dominguez

Thanks for reporting this. I'll leave the issue open to remind myself to take a look at this and test if there is a difference.

mvanthoor avatar Jul 09 '24 20:07 mvanthoor