Michael van Tellingen comments

Results 108 comments of


                                            Michael van Tellingen

Initial apply fails because of aws_acm_certificate_validation is missing

"moved" this issue to https://github.com/mach-composer/mach-composer-plugin-aws/issues/4

Should we implement Terraform code through AWS CDK?

For reference, see #83

Add template option to extend generated Terraform configuration

I think this can now be achieved via plugins. Of course creating a plugin for only adding a provider seems overkill. But it's quite easy to create a reusable provider...

add support for removal of default execution domain on AWS

With all the recent changes this PR is now out of date. Can you submit a new PR to the plugin at https://github.com/mach-composer/mach-composer-plugin-aws

failed/still failing/fixed - options to chose when to send notifications

+1 for me. We only want to be notified via hipchat if a build fails (or is unstable).

failed/still failing/fixed - options to chose when to send notifications

See that this is already implemented in HEAD, and working just fine :-) Thanks

Empty translations

Can you describe which actions we need to take? Or submit a PR

Empty translations

Well the issue is that the sk_SK translation exists in transifex, and since transifex has the worst UX ever I have no idea how to delete it there :( If...

Update index.rst with a new example

I'm not sure if we can use that domain instead. It would be best to host our own example wsdl service. Need to think about this

Transport with attachment

Thanks for this. I'm afraid this will take some refactoring to integrate nicely with zeep. What will help however is a couple of unittests. Are you able to add those?