java-fluent-validator icon indicating copy to clipboard operation
java-fluent-validator copied to clipboard

.critical() should not be needed when fail-fast strategy is used

Open bakatz opened this issue 6 years ago • 1 comments

It seems strange to require .critical() on each rule when failfast is already enabled - just wanted to file a suggestion to consider changing this design to not require the extra .critical() call

Side note: nice work on this library. This is the best alternative to FluentValidation (.NET library) that I've found for java. Thanks!

bakatz avatar Nov 26 '19 02:11 bakatz

Hi @bakatz,

It makes sense to say that making the critical statement less verbose when failFastRule is enabled.

I will work on this issue and the next release will be available.

Thanks for the feeback, I really appreciate it!

Regards,

mvallim avatar Nov 27 '19 02:11 mvallim