Murray Wood
Murray Wood
Ugh. phpcs seems to be finding more issues each time I fix the reported ones. I'm a tad worried that what was meant to be a straightforward PR is going...
Hi @opengeek, yeah that should be easy enough. Mark mentioned he'd prefer there be no mode at all, so I've got another approach in testing that does things the same...
Alternative PR is here: #16095
Updated to make the mode naming generic, and remove any mention of static elements within the media source. 👍🏻
The intention there was so it only worked with a local filesystem media source. But if I misunderstood and it should work for any kind, then moving that to modMediaSource...
That sounds fair! I've just restricted the media source combobox on the element panels to only list media sources with the `class_key` of `MODX\Revolution\Sources\modFileMediaSource`. This was done by adding an...
> Is this PR still relevant? Sorry for the delay @JoshuaLuckers ! This and the alternative PR can probably be closed now. Right @opengeek ?
No longer needed. Closing!
This *should* be able to be fixed with `#modx-resource-main-right .x-form-field-wrap.x-form-field-trigger-wrap {max-width:100%;}` however this means the inner drop-down fields may be out of alignment. I'll edit this with an update if...
True.. Though it would need some logic to add a wrapper panel if there are elements there and hide it if not. It'd be great for fields to be inserted...