chat icon indicating copy to clipboard operation
chat copied to clipboard

Get a conversation between two participants - (Works only for direct messages)

Open pmochine opened this issue 4 years ago • 7 comments

Sorry, I'm too lazy to change the readme and to pull it here. But I'm currently migrating to the newest version and I was struggling why

$conversation = Chat::conversations()->between($participantModel1, $participantModel2)

is not working. It's because between sets the direct message to true. Would be nice to have a hint in the readme

pmochine avatar Jan 15 '20 13:01 pmochine

I just tried testing the common function, and before that I looked at your code and could not find it anywhere. Nonetheless here is an example:

return \Chat::conversations()->common([$order->seller, $order->buyer]);

leads to:

Call to undefined method Musonza\Chat\Services\ConversationService::common()

pmochine avatar Jan 16 '20 03:01 pmochine

Hey, yeah that's a method that's no longer in this version. I have to update the readme

musonza avatar Jan 16 '20 03:01 musonza

Hey, yeah that's a method that's no longer in this version. I have to update the readme

Thanks :)

pmochine avatar Jan 17 '20 09:01 pmochine

Hey, yeah that's a method that's no longer in this version. I have to update the readme

Hey @musonza Can I ask you why it was removed?

theMSY avatar Mar 02 '20 16:03 theMSY

@theMSY I believe it was giving incorrect results since I had implemented it with user ids only. It needed work and I didn't have time but if you need it I would be glad to help if you have a PR started

musonza avatar Mar 02 '20 16:03 musonza

, it sounds like an opportunity to contribute. I would gladly help to implement it once I'm free. 😄

theMSY avatar Mar 02 '20 16:03 theMSY

hello, have you correct it?

nyoumi avatar Oct 19 '21 16:10 nyoumi