Helixbase icon indicating copy to clipboard operation
Helixbase copied to clipboard

obj\[Configuration]\NuGet\[Guid] folder included in output

Open svenkle opened this issue 3 years ago • 5 comments

Posting this for review/discussion or to help others.

There is a little/strange issue when GlassMapper and Helix Publish Profile are used in conjunction. Each project that references GlassMapper has a obj folder with the .cs and .config files from GlassMapper in a format similar to obj\[Configuration]\Nuget\[Guid]. Unfortunately this folder is copied to the publish target by HPP and it really shouldn't be there. To work around this I've updated my NuGet references as shown below:

<PackageReference Update="Glass.Mapper.Sc.100" Version="5.8.173">
    <IncludeAssets>compile</IncludeAssets>
</PackageReference>

Reference for NuGet: https://docs.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files

svenkle avatar Apr 08 '21 07:04 svenkle

Hi @svenkle - this is logged in glass.... https://github.com/mikeedwards83/Glass.Mapper/issues/432

Hopefully we'll get it fixed soon

muso31 avatar Apr 08 '21 07:04 muso31

@muso31 sure it's a GlassMapper issue, but given the fact this repository depends on both GlassMapper and HPP wouldn't it be better to apply a fix until a time that it is resolved? There are many open issues and several PRs in that repository so it seems unlikely to be fixed any time soon.

svenkle avatar Apr 08 '21 08:04 svenkle

@svenkle I have access to Glass as I'm helping maintain the solution, there's already a branch with a fix in place. We'll look into getting it tested and released asap - https://github.com/mikeedwards83/Glass.Mapper/tree/feature/loadingchanges

muso31 avatar Apr 08 '21 08:04 muso31

..Will also look into applying your fix in the meatime

muso31 avatar Apr 08 '21 08:04 muso31

@svenkle I have access to Glass as I'm helping maintain the solution, there's already a branch with a fix in place. We'll look into getting it tested and released asap - https://github.com/mikeedwards83/Glass.Mapper/tree/feature/loadingchanges

Great! Can you also approve my PR in that repo 😄.

svenkle avatar Apr 08 '21 12:04 svenkle