Album artist view doesn't work for compilations

[claes-bergefall]

Follow up on issue #92 (#93 possible related as well)

When enabling "Only Album Artists", the album artist for compilation albums doesn't show up in the Artists list. The albums are shown in the Albums list with the correct album artist tag (and in the Tracks list with the correct artist tag).

It looks like the artist list only show artists where the album artist and the artist tags are equal. I had a look at your commit for #92 and it seems to confirm it (in the join on artist between artists and tracks).

Example: I have a bunch of soundtrack albums (Matrix, Top Gun etc) where I have set the album artist tag to 'Soundtracks'. The artist tag is set to the correct artist for each track. If I disable "Only Album Artists" the Artists list show each individual artist as expected. If I enable "Only Album Artists", there is no Soundtracks artist as expected

[kelsos]

Thank you for reporting.

If I disable "Only Album Artists" the Artists list show each individual artist as expected. If I enable "Only Album Artists", there is no Soundtracks artist as expected.

That confused me a bit to be honest, I am not sure I properly understand what doesn't work properly. Could you explain in more detail?

I am doing some huge refactoring at the moment, and soon I will have to go through the library. It would help to have a clearly described problem, so that I can write some tests to make sure that everything works properly.

[claes-bergefall]

I'll try to explain a bit more. Take the soundtrack for Top Gun for example. The first 3 tracks are as follows:

1. "Danger Zone" by Kenny Loggins
2. "Mighty Wings" by Cheap Trick
3. "Playing with the boys" by Kenny Loggins

I have them ripped in flac. The ALBUMARTIST tag for all 3 tracks is set to "Soundtracks". The ARTIST tag for each track is set to the individual artist (i.e. Kenny Loggins or Cheap Trick). I don't have any other tracks/albums with either of these artists

With "Only Albums Artists" unticked, Kenny Loggins and Cheap Trick are listed as individual artists in the artists list (as expected)

With "Only Albums Artists" ticked, Kenny Loggins and Cheap Trick are not listed as individual artists in the artists list (as expected). But there is also no artist named "Soundtracks" (i.e. the ALBUMARTIST tag) in the list as I would expect. MusicBee itself shows "Soundtracks" as an individual artist, but the remote app doesn't.

[claes-bergefall]

I suspect the problem is in the getAlbumArtists method. It's doing a join between Artist and and Track, but judging from the debug log, the browseartists call only return the ARTIST tags so the join would effectively filter out anything where the ALBUMARTIST and ARTIST are different

[kelsos]

Ok thanks for taking time to explain. Like I mentioned before I am doing a huge rewrite of the application so I will make sure that this is fixed.