lovely-forks icon indicating copy to clipboard operation
lovely-forks copied to clipboard

should not be extra margin before load fork data

Open tjx666 opened this issue 3 years ago • 4 comments

You can see there is extra margin before load for data

image

tjx666 avatar Dec 15 '21 17:12 tjx666

Hi @tjx666!

Thanks for the report!

However, the extra space is actually explicitly included in order to avoid jumps in the layout once the data does load. If it doesn't load (or if there is no notable fork), then too there is no jump, but at the cost of the header taking about 12px more space on the desktop.

musically-ut avatar Dec 15 '21 17:12 musically-ut

@musically-ut we can move the display position to here or other better:

image

tjx666 avatar Dec 15 '21 17:12 tjx666

That's a good idea, I can see that as being an extension option.

However, the primary reason I made this extension was so that when I was just about to create an issue on a repo, I should be able to see the notable forks without leaving the issues page. Putting that info on the repo front would remove it from the other tabs.

musically-ut avatar Dec 15 '21 17:12 musically-ut

In fact, I ussualy this repository is long time no maintained by check it's last commit. I would better just want click somewhere jump to the stat page for example: https://techgaun.github.io/active-forks/index.html#musically-ut/lovely-forks

tjx666 avatar Dec 15 '21 17:12 tjx666