conpot icon indicating copy to clipboard operation
conpot copied to clipboard

Refactor bin/conpot

Open glaslos opened this issue 4 years ago • 4 comments

  • Would be nice if it can be a file conpot.py with Python extension. setup.py needs to be updated to make this possible.
  • The file should only do flags, startup message and initializing/running Conpot.
  • Everything template should be in a separate module.
  • Everything starting protocols should be in a separate module.
  • Everything logging should be in separate module.
  • Everything moved into a separate module should have test coverage.

glaslos avatar Nov 22 '20 23:11 glaslos

Hi, Can I try this out?

NishantPuri99 avatar Jan 10 '21 18:01 NishantPuri99

Of course, no need to ask :)

glaslos avatar Jan 10 '21 23:01 glaslos

Ideally there would also be tests where possible. Don't know if you want to add this to the requirements.

I realize that testing main() is notoriously difficult, but with a split in separate modules (or at least functions) this should be much easier.

srenfo avatar Jan 30 '21 21:01 srenfo

@NishantPuri99 have you had any success?

glaslos avatar Feb 20 '22 13:02 glaslos