musescore
Feat: Restoring instruments list while switching back and forth between in instruments and templates
Resolves: #14342
- [x] I signed the CLA
- [x] The title of the PR describes the problem it addresses
- [x] Each commit's message describes its purpose and effects, and references the issue it resolves
- [x] If changes are extensive, there is a sequence of easily reviewable commits
- [x] The code in the PR follows the coding rules
- [ ] There are no unnecessary changes
- [x] The code compiles and runs on my machine, preferably after each commit individually
- [ ] I created a unit test or vtest to verify the changes I made (if applicable)
@cbjeukendrup I commit my progress. Not getting any error but not restoring the instruments list while switching between two. Main logic is not working, I think we have to do some changes in addSelectedInstrumentsToScore() function in ChooseInstrumentsPage.qml. There we call addInstruments() that is not exist anymore. Please ignore code comments as of now, I will delete those in my final and working commit.
@chilkaditya Sorry for the delay, some other work came in between, but now I've found the reason that it was still not working, see the last third commit that I added. Solving it was in the end not difficult, but finding it was a bit tricky indeed! So I think this PR is now ready. Thanks for your work!
@chilkaditya Sorry for the delay, some other work came in between, but now I've found the reason that it was still not working, see the last third commit that I added. Solving it was in the end not difficult, but finding it was a bit tricky indeed! So I think this PR is now ready. Thanks for your work!
Ok, I understand what was the problem. Thank you again for your help.
Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved https://github.com/musescore/MuseScore/issues/14342 FIXED
