MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard

Mode-specific settings for automatic score panning

Open svetter opened this issue 1 year ago • 0 comments

Resolves: #23901 Resolves: #20512

For more fine-grained control over when the canvas can be moved automatically, this PR introduces a new section in the canvas preferences with the following settings:

  • [x] Pan and scroll score automatically in note/text input mode
  • [x] Pan and scroll score automatically during playback
  • [x] Pan and scroll score automatically otherwise

All three settings default to true. The second one is duplicated in the playback options popup, where the single setting for enabling and disabling automatic score panning was found before my changes.

All instances in the code where the previous unified setting was checked have been assigned to one of the three new settings, so either to note/text input, playback or other, and the new settings work accordingly. Actions whose only or primary purpose is moving the canvas (according to my interpretation) are always performed (this addresses #20512).

As I am relatively new to the codebase, please let me know if there are any problems with code style, variable naming, UX design etc..

  • [x] I signed the CLA
  • [x] The title of the PR describes the problem it addresses
  • [x] Each commit's message describes its purpose and effects, and references the issue it resolves
  • [x] If changes are extensive, there is a sequence of easily reviewable commits
  • [x] The code in the PR follows the coding rules
  • [x] There are no unnecessary changes
  • [x] The code compiles and runs on my machine, preferably after each commit individually
  • [ ] I created a unit test or vtest to verify the changes I made (if applicable)

svetter avatar Aug 27 '24 18:08 svetter