MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard

Disable certain properties when not needed

Open XiaoMigros opened this issue 9 months ago • 1 comments

This PR disables the Text Offset option for text in line elements when there is no text to be offset. Additionally, the 'Gap between text and line' option is disabled when there is no text to leave a gap between.

image

  • [x] I signed the CLA
  • [x] The title of the PR describes the problem it addresses
  • [x] Each commit's message describes its purpose and effects, and references the issue it resolves
  • [ ] If changes are extensive, there is a sequence of easily reviewable commits
  • [x] The code in the PR follows the coding rules
  • [x] There are no unnecessary changes
  • [x] The code compiles and runs on my machine, preferably after each commit individually
  • [ ] I created a unit test or vtest to verify the changes I made (if applicable)

XiaoMigros avatar Apr 27 '24 15:04 XiaoMigros

Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved

zacjansheski avatar May 01 '24 14:05 zacjansheski

@zacjansheski You might want to re-check this briefly

cbjeukendrup avatar Jun 06 '24 16:06 cbjeukendrup

Re-Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved

zacjansheski avatar Jun 06 '24 19:06 zacjansheski