MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard

Fix #22601: Include text alignment in line layout

Open XiaoMigros opened this issue 9 months ago • 3 comments

Resolves: #22601

  • [x] I signed the CLA
  • [x] The title of the PR describes the problem it addresses
  • [x] Each commit's message describes its purpose and effects, and references the issue it resolves
  • [ ] If changes are extensive, there is a sequence of easily reviewable commits
  • [x] The code in the PR follows the coding rules
  • [x] There are no unnecessary changes
  • [x] The code compiles and runs on my machine, preferably after each commit individually
  • [x] I created a unit test or vtest to verify the changes I made (if applicable)

XiaoMigros avatar Apr 27 '24 15:04 XiaoMigros

It seems that something similar applies to the end text: Scherm­afbeelding 2024-04-27 om 18 37 57 The line continues below the text, while I think it should end before. But this also depends on the endTextPlace property, which should probably behave similar to beginTextPlace. It's difficult to test, because the UI for it is mostly missing in MS4's properties panel.

It would be good to also add a new VTest to this PR, ideally one that verifies all combinations of TextPlace and Alignment, for begin and end text.

cbjeukendrup avatar Apr 27 '24 16:04 cbjeukendrup

It seems that something similar applies to the end text:

Should the end text then also use the 'gap between text and line' property? currently there is no distance added at all

XiaoMigros avatar Apr 27 '24 19:04 XiaoMigros

Should the end text then also use the 'gap between text and line' property? currently there is no distance added at all

Yes, this makes sense to me. Doubtlessly, the next thing people will ask for is separate controls for begin/continue/end text gap, but that would be a separate feature request.

cbjeukendrup avatar Apr 28 '24 19:04 cbjeukendrup