horizontal frame and system break prevent courtesy keysigs

[SystemsModelling]

Issue type

Engraving bug (incorrect score rendering)

Bug description

Inserting a horizontal frame and entering a break at that frame breaks the stave all right but now there are no courtesy accidentals

Divisi arrows are beyond RH margin of bars.

Entering a break at end bar creates courtesy accidentals, as expected.

Suppose we want the divisi arrows to end at the same right hand margin as the rest of the bars? Instead of entering a system break, inserting a horizontal frame at bar 5 and entering a break at that frame breaks the stave all right but now there are no courtesy accidentals

MuseScore Version

MuseScore version (64-bit): 4.2.1-240230937, revision: github-musescore-musescore-d757433

Regression

No

Operating system

OS: Windows 10 Version 2009 or later, Arch.: x86_64

[zacjansheski]

@SystemsModelling

It would be helpful to have a screen capture and/or a musescore file showing what you are trying to do.

You can attach musescore files here by compressing or using .zip

[SystemsModelling]

@zacjansheski my original post has a .doc file attached containing several screenshots of different outcomes.

"[Divisi arrows, Hframe, accidentals.docx]"(https://github.com/musescore/MuseScore/files/14898822/Divisi.arrows.Hframe.accidentals.docx)

[zacjansheski]

Not everyone here can open a .doc file

[Jojo-Schmitz]

from that docx:

Divisi arrows are beyond RH margin of bars. Entering a break at end bar creates courtesy accidentals, as expected. Suppose we want the divisi arrows to end at the same right hand margin as the rest of the bars? Instead of entering a system break, inserting a horizontal frame at bar 5 and entering a break at that frame breaks the stave all right but now there are no courtesy accidentals

[SystemsModelling]

That's very kind of you Jojo, thank you. I hadn't thought of a .doc problem, I just assumed every OS had an app for that. Would a PDF be better in order to interleave text and images? P

[Jojo-Schmitz]

Even better just use plain text and images

[XiaoMigros]

I'm wondering what the best way to solve this would be... A toggle in properties for horizontal frames "Display courtesy keysig, timesig, clef in previous measure" ?

[Jojo-Schmitz]

I don't think that's needed, it should just work, unconditionally, just as if those frames weren't there. Only a section break should not display them (unless setup differently, it does have these toggles)

[XiaoMigros]

Even when the new measure is on the same system? Because there I would argue it shouldn't be the default, but the user should still have control over whether to display it or not

[Jojo-Schmitz]

If the user wants control, (s)he should use a section break

[XiaoMigros]

Section breaks won't work in cases like this...

[Jojo-Schmitz]

Ah, indeed not for horizontal frames, I had forgotten about that. They imply a system break.

[XiaoMigros]

Yes, system break on a horizontal frame, which is only one of the many use cases

[Jojo-Schmitz]

But here we're dealing with horizontal frames and system breaks

[XiaoMigros]

Well, yes. However since there are other instances where different behavior could be wanted, I think a more encompassing solution is best (see my example above)

[iainhallam]

Section breaks won't work in cases like this...

In this case, it seems like you wouldn't want the courtesy key signature, but by default it wouldn't be generated anyway?

[sammik]

I'm wondering what the best way to solve this would be... A toggle in properties for horizontal frames "Display courtesy keysig, timesig, clef in previous measure" ?

I dont think any new option is needed. Option to show / not show courtesy keysig is already included in "normal" key signature.

Problem here is, "previous measure", or "last measure of previous system" is not real measure. So solution would be, to ensure, in creating courtesy keysig, to create them to real measure (skip frames).

Same way, like it does, when frame is at the begining of new system.

[XiaoMigros]

But in cases like this, the user may sometimes want a courtesy and sometimes not. That's why it should be controllable

[sammik]

But in cases like this, the user may sometimes want a courtesy and sometimes not. That's why it should be controllable

I cannot see image

[Jojo-Schmitz]

Interesting I can't either but could earlier

[XiaoMigros]

fixed

[sammik]

Section breaks won't work in cases like this...

I think, this is different case. I see it as a nice feature request, and original post as a bug.

But if having this nice option, defaults in theese cases should be oposite.

If line break, courtesy keysig should be on, if not line break, courtesy keysig should be off by default. (Of course depending on score style settings too).

[Jojo-Schmitz]

I wonder whether it is related to #15943/#16530, having the same root cause?

[Jojo-Schmitz]

Isn't this a duplicate of #19759?