MuseScore
MuseScore copied to clipboard
musescore
New Courtesy Accidentals plugin
The current courtesy accidentals plugin is limited in where it adds courtesy accidentals, and the UI for configuring the settings isn't particularly good-looking. In an attempt to tackle both of those issues, here's a new Courtesy Accidentals plugin.
- [x] I signed the CLA
- [x] The title of the PR describes the problem it addresses
- [x] Each commit's message describes its purpose and effects, and references the issue it resolves
- [ ] If changes are extensive, there is a sequence of easily reviewable commits
- [x] The code in the PR follows the coding rules
- [x] There are no unnecessary changes
- [x] The code compiles and runs on my machine, preferably after each commit individually
- [ ] I created a unit test or vtest to verify the changes I made (if applicable)
@XiaoMigros Following on your recent work on the Retrograde plugin, I was thinking it would be nice to get this one in as well. Would you be willing to rebase it?
Can do! If possible, I'd like for the plugin to parse ornament accidentals too, meaning this would wait until #28505 is merged.
@XiaoMigros, a fellow user reported this issue with the Courtesy Accidentals plugin, #16565, FYI.
@XiaoMigros Now that https://github.com/musescore/MuseScore/pull/28505 has been merged, it would be great if you could look into this PR again!
@XiaoMigros While working on https://github.com/musescore/MuseScore/pull/28839 I temporarily forgot about this PR, so now there will be some conflicts in configure.qml. Sorry for that!
Sorry, I didn't mean to push that commit yet. The currently public version should now work correctly, but is not yet compatible with ornaments. I am also rewriting parts of the UI to be less clunky...