MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard

Published 20 hours ago • verified publisher icon musescore

[WIP] Implement #14209-1: Expose options to set a start hook on a line

Open Gravifer opened this issue 2 years ago • 1 comments

Resolves: #14209-1

  • [x] I signed the CLA
  • [x] The title of the PR describes the problem it addresses
  • [x] Each commit's message describes its purpose and effects, and references the issue it resolves
  • [x] If changes are extensive, there is a sequence of easily reviewable commits
  • [x] The code in the PR follows the coding rules
  • [ ] There are no unnecessary changes
  • [ ] The code compiles and runs on my machine, preferably after each commit individually
  • [ ] I created a unit test or vtest to verify the changes I made (if applicable)

Gravifer avatar Jan 15 '23 06:01 Gravifer

Made changes to the UI and the C++ intetface; my C++ toolchain broke a while ago due to some censorware and I've only been eyeballing it, so there's still a good chance it won't work. I'll try and fix it later.

Gravifer avatar Jan 15 '23 06:01 Gravifer

(and please delete the old code, rather than commenting it -- but I'm sure you were going to do that anyway 😉)

Indeed :D I tend to leave old comments in comments only in the first commit of a branch (always worried about messed up diff views even when not necessary). A thing is that I haven't been able to get a viable build yet; my local compilers are still effed up, and the artifact for me simply exitted after the startup splash. I haven't figured out how to get a log or sth yet.

Gravifer avatar Jan 20 '23 15:01 Gravifer

@cbjeukendrup I still haven't been able to set my toolchain right. Do feel free to assign this to any contributor if they are interested. I hope I'll be more productive soon.

Gravifer avatar Feb 22 '23 08:02 Gravifer

@Gravifer I'm sorry to hear that! Since you're already so close to a solution, I might cherry-pick the changes to a new PR and add the finishing touches myself. Is that okay for you?

cbjeukendrup avatar Feb 25 '23 17:02 cbjeukendrup

@Gravifer I have created a new PR, https://github.com/musescore/MuseScore/pull/16685, building on your work, so I will close this PR. Thanks for your contribution!

cbjeukendrup avatar Mar 07 '23 11:03 cbjeukendrup

@Gravifer I'm sorry to hear that! Since you're already so close to a solution, I might cherry-pick the changes to a new PR and add the finishing touches myself. Is that okay for you?

Totally fine~ I've been caught up in schoolwork and haven't been able to code for a while. Glad to see MuseScore become more and more refined with the effort of all :D

Gravifer avatar Mar 30 '23 13:03 Gravifer