MuseScore
MuseScore copied to clipboard
musescore
Fix #15473: No platform menu bar support on Linux
Resolves: #15473
Native menu bar support is only implemented for macOS. This pull request contains changes that will enable it on Linux-based systems as well (for example the global menu bar in KDE Plasma). Uses D-Bus (com.canonical.AppMenu.Registrar) to check whether global menu is available.
I've tested this in KDE Plasma and it properly detects whether global menu is enabled.
- [x] I signed the CLA
- [x] The title of the PR describes the problem it addresses
- [x] Each commit's message describes its purpose and effects, and references the issue it resolves
- [x] If changes are extensive, there is a sequence of easily reviewable commits
- [x] The code in the PR follows the coding rules
- [x] There are no unnecessary changes
- [x] The code compiles and runs on my machine, preferably after each commit individually
- [x] I created a unit test or vtest to verify the changes I made (if applicable)
@adazem009 Great!
In order for the unit tests to be successful, could you please update with the master
The unit test failure is also on the latest master branch, but only sometimes. I still need to clean that up...
I've restarted the check for now, let's see whether it passes this time :)
@adazem009 Great!
In order for the unit tests to be successful, could you please update with the master
Unit tests are successful now.
@cbjeukendrup do you have any other suggestions? or is it ready for merge? :)
@cbjeukendrup do you have any other suggestions? or is it ready for merge? :)
It's ready for merge. I've already tested it on Windows and macOS just to be sure that it doesn't break anything.
@cbjeukendrup I don't have KDE Plasma. I have only Ubuntu and Mint and as I know it's not easy to enable Global menu there..
I've tested this PR on Win10,Mac13 and Linux Mint and didn't found any differences with master. So, if it's safe we can merge it to master.
