[MU4 Issue] Horizontal frame - Properties - "Display key, brackets and braces" should also mention "clef"

[sammik]

Describe the bug In properties of Horizontal panel, there is tick named "Display key, brackets and braces". Should be "Display clef, key, brackets and braces".

To Reproduce Steps to reproduce the behavior:

1. Insert horizontal panel to score
2. Click Properties panel

Expected behavior Also "clef" should be mentioned

Screenshots

https://user-images.githubusercontent.com/1646034/210225712-6c5ea744-6c3e-4207-88ec-51ec9f016da5.mp4

[cbjeukendrup]

Maybe we should make clear that this checkbox is about the next measure: Display clef, key and brackets before the next measure (and I think "brackets" can be used as a general term to include "braces", so we can drop "braces".)

[sammik]

May be "in the next measure" instead of "before the next measure"? Or change it to oposite "Hide clef, key and brackets"?

[maddy020]

Hey @sammik I would love to work on this issue Please assign it to me

[sammik]

@cbjeukendrup, please ^^^

[cbjeukendrup]

Reg. the conclusion for what the text should be: I would propose that we go for: Display clef, key and brackets in the next measure

Everyone happy with that?

[octopols]

@cbjeukendrup if the issue is still not fixed can you assign it to me?

[octopols]

For translations should I use google translate or should I just mark them unfinished for now?

[cbjeukendrup]

You don't need to worry about translations at all :)

You only need to make the string translatable by writing it like qsTrc("inspector", "<the string goes here>"). Then, at some point, we (the "in-house" team) will run a program that extracts all translatable strings from the source code, and sends them to a translation platform called Transifex. There, they will be translated by volunteering MuseScore users from all countries. At the moment of the release, we download the translations from Transifex, and package them with the app.

[octopols]

You don't need to worry about translations at all :)

You only need to make the string translatable by writing it like qsTrc("inspector", "<the string goes here>"). Then, at some point, we (the "in-house" team) will run a program that extracts all translatable strings from the source code, and sends them to a translation platform called Transifex. There, they will be translated by volunteering MuseScore users from all countries. At the moment of the release, we download the translations from Transifex, and package them with the app.

So, I only need to make changes to the HorizontalFrameSettings.qml file and leave the language files (.ts) the way they are right?

[cbjeukendrup]

Yes, that's right!

[Jojo-Schmitz]

Hmm, if we'd use "Display brackets, clef and key in the next measure" the order in the text matches the order of the elements in the score, won't that be better and more logical?

[Jojo-Schmitz]

And isn't it key signature rather than just `key? Already led me to a wrong German translation (Taste <-> key <-> Schlüssel <-> clef, but key signature <-> Tonart)

[octopols]

And isn't it key signature rather than just `key? Already led me to a wrong German translation (Taste <-> key <-> Schlüssel <-> clef, but key signature <-> Tonart)

I don't know a lot about music theory, whatever fits right I'll update the string to that.

[cbjeukendrup]

Yes, I agree with @Jojo-Schmitz. Also, probably clefs (plural) is more correct. So that would give us: Display brackets, clefs and key signature in the next measure

[Jojo-Schmitz]

It is either only one clef or key signatures

Ah, no. In case of more than one staff it'd be multiple (potentially different) clefs, but not different keysigs

Or... Multiple key signatures are also possible in case of local ones or for transposing instruments, depending on the concert pitch setting?

[cbjeukendrup]

Not sure if I agree... I'm inclined to regard the key signature as one object for all staves together, while clefs are clearly distinct elements on each staff. @oktophonie what's your opinion?

[Jojo-Schmitz]

Even with local keysigs?

What about time signatures, shouldn't those be shown (and them get mentioned) too? Edit: probably not.

To shorten the string somewhat, we could pprobably drop the 'the'

[oktophonie]

Not sure if I agree... I'm inclined to regard the key signature as one object for all staves together, while clefs are clearly distinct elements on each staff. @oktophonie what's your opinion?

Sounds best to me to have them all plural, but it's not a big deal.

[octopols]

Yes, I agree with @Jojo-Schmitz. Also, probably clefs (plural) is more correct. So that would give us: Display brackets, clefs and key signature in the next measure

Should I update the string with this and make it 'key signatures' instead?

[cbjeukendrup]

Yes, let's go for that!

[octopols]

Changed the string https://github.com/musescore/MuseScore/pull/16008/commits/30a0c43b8c447238b2f25ba85c955f670dd5f4f4