MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard

[MU4 Issue] Removing measures crashes MuseScore 4

Open marcelroed opened this issue 2 years ago • 7 comments

Describe the bug I'm working on a score I made in 3.x, and have extended it by adding the primo part to a 4-handed piece. I am able to add measures, but when I try to delete them with "remove selected range ⌘⌫," Musescore 4 crashes. I haven't done anything other than basic operations to the score, so this is quite crippling in that I'm not able to remove measures in any other way.

To reproduce Steps to reproduce the behavior:

Open attached MWE file in MuseScore 4. Select some of the empty measures toward the end of the score. Tools > Remove selected range Musescore crashes

Deleting measures seems to work fine with Musescore files that I create from scratch.

Expected behavior The measures should be gone, and Musescore should not crash.

Screenshots image

Platform information OS: macOS 13.1, Arch.: x86_64, MuseScore version (64-bit): 4.0.0-223472200, revision: github-musescore-musescore-5485621

I've included an example example.mscz.zip

marcelroed avatar Dec 22 '22 17:12 marcelroed

Same here on OS: Linux Mint 21.1, Arch.: x86_64, MuseScore version (64-bit): 4.0.0-223472159, revision: github-musescore-musescore-5485621

Grillzombie avatar Dec 22 '22 22:12 Grillzombie

I can reproduce the crash with this file, but it is probably because the file is corrupted. The corruption might have happened because of measures being added; that's a known case currently, see #15185. Strange though that the corruption is also in the full score (see the last few measures), because I believe that the known corruption would only affect the part scores. So there's more going on.

Probably the best thing you can do right now is creating a new file and copying the not-corrupt-looking measures to that new file. Or, if you still have the MS3 file and haven't done a lot in MS4 yet, go back to the MS3 version.

@Grillzombie Do you mean you can reproduce the issue with the same score, or with a different one?

cbjeukendrup avatar Dec 23 '22 00:12 cbjeukendrup

Is there any reasonable way to check if a measure is corrupt or not? I'm not quite sure what I can copy and not to a new MS4 file. I did the entire Primo part in MS4, so I don't think going back to MS3 is an option.

marcelroed avatar Dec 23 '22 02:12 marcelroed

@cbjeukendrup With the score provided from marcelroed

Grillzombie avatar Dec 23 '22 07:12 Grillzombie

Should it be allowed to enter measures in parts anyway?

oMrSmith avatar Dec 23 '22 09:12 oMrSmith

Is there any reasonable way to check if a measure is corrupt or not? I'm not quite sure what I can copy and not to a new MS4 file. I did the entire Primo part in MS4, so I don't think going back to MS3 is an option.

@marcelroed This functionality is currently missing, but it is added back in #15488. To try it out, you can download the macOS test version here: https://github.com/musescore/MuseScore/actions/runs/3758295289 (bottom of the page)

I already did this for you, and it turns out only measure 62 is problematic. So you can safely copy the other measures to a new file to continue composing.

The big question remains: how has this corruption happened? Did you any actions like inserting measures, changing the time signature after writing notes, or anything that may move notes to different measures etc.?

cbjeukendrup avatar Dec 23 '22 20:12 cbjeukendrup

Same issue here with a different score. The problem was resolved though: by cutting and re-pasting the part I suspected to corrupt the file.

OS: Ubuntu 22.04.1 LTS, Arch.: x86_64, MuseScore version (64-bit): 4.0.0-223472159, revision: github-musescore-musescore-5485621

akberg avatar Jan 11 '23 21:01 akberg

Since this only happens in corrupted files, and the cause of the corruption should be fixed in 4.0.1, I'm thinking we can close this. However, if anyone sees a new corruption in 4.0.1 or newer, or a crash when deleting measures in non-corrupted scores, please let us know.

cbjeukendrup avatar Jan 16 '23 18:01 cbjeukendrup

Since this only happens in corrupted files, and the cause of the corruption should be fixed in 4.0.1, I'm thinking we can close this. However, if anyone sees a new corruption in 4.0.1 or newer, or a crash when deleting measures in non-corrupted scores, please let us know.

@cbjeukendrup This was closed as won't fix, correct?

DmitryArefiev avatar Mar 02 '23 14:03 DmitryArefiev

Yes, that's right. The cause of the crash was a corrupted score, and the cause of the corruption had been fixed in 4.0.1, so it won't happen with other scores.

cbjeukendrup avatar Mar 02 '23 15:03 cbjeukendrup