MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard

[MU4 Issue] Remove default Qt button icons

Open Ciubix8513 opened this issue 2 years ago • 3 comments

Default Qt button icons appear in some dialogues

Found in:

  • Page settings
  • About Qt
  • Transpose
  • Style
  • Create tuplet
  • Staff text properties
  • Staff/Part properties

There are probably more places where this issue can be found

Screenshots image

Platform information

  • OS: Linux

Ciubix8513 avatar Dec 22 '22 09:12 Ciubix8513

Why remove them? They don't show in Windows BTW, so what OS are you seeing them in? Edit: OK, Linux...

Jojo-Schmitz avatar Dec 22 '22 09:12 Jojo-Schmitz

Consistency, other windows don't have them.

For example here are the buttons of Prefrences window: image

They also clash with the clean UI of MU4

Ciubix8513 avatar Dec 22 '22 10:12 Ciubix8513

I think the best way to solve this is using QStyle, by overriding the standardPixmap and/or standardIcon methods. We already have a QStyle subclass, see uitheme.cpp, so adding this method override should be doable enough to call this a good first issue for anyone with a little bit of experience with Qt (or not even that).

cbjeukendrup avatar Dec 24 '22 00:12 cbjeukendrup