MuseScore
MuseScore copied to clipboard
error_details
Resolves: https://github.com/musescore/MuseScore/issues/15226
@RomanPudashkin I've tested this on macOS using all your supplied scores, as well as the "Avengers" score we were previously using. ✅ Both "types" of error dialog are being triggered correctly (I.e. the "open anyway" version, and the "get help" version) ✅ "Get help" link points to correct URL ✅ "Show details" text strings are correctly laid-out ✅ "Copy" functionality works Let us know when the accessibility navigation is implemented and I'll give that one quick look too 🙂
Seems this PR needs the "strings" label, as it adds translatable strings? And wouldn't that make it not fitting 4.0.1? Wh1ch would be rather unfortunate...
@RomanPudashkin I've given this another test on macOS – all looks good (and keyboard navigation works well too). Just one quibbly point: could we please have a space after the punctuation marks at these points?
@bkunda That's the same problem again as #14560... (where the only solution is to update to Qt 5.15.3+)
@bkunda That's the same problem again as #14560... (where the only solution is to update to Qt 5.15.3+)
oh god, how droll. Ok then @RomanPudashkin this is good to go from my POV!