MuseScore
MuseScore copied to clipboard
Fix playback toggle on dock/undock
Resolves: #15302
Allows the playback toggle to persist after undocking/docking the playback toolbar
- [x] I signed the CLA
- [x] The title of the PR describes the problem it addresses
- [x] Each commit's message describes its purpose and effects, and references the issue it resolves
- [x] If changes are extensive, there is a sequence of easily reviewable commits
- [x] The code in the PR follows the coding rules
- [x] There are no unnecessary changes
- [x] The code compiles and runs on my machine, preferably after each commit individually
- [x] I created a unit test or vtest to verify the changes I made (if applicable)
Sorry for force-pushing, I have no clue how to amend a commit without doing such, and I didn't want to make more commits than were necessary
@FigmentBoy Force-pushing to your own PR branch is perfectly fine! Possibly even the best way.
@cbjeukendrup Thank you for letting me know. I'm a little bit new to open-source contributions so I am not too sure of the best practices.
@FigmentBoy Thanks for fixing it! it would be great if you could squash the commits into one.
Tested #15302 on Win10, Mac12, LinuxMint 22.04 - FIXED
@FigmentBoy Thanks for fixing it! it would be great if you could squash the commits into one.
There you go! Unintentionally synced my fork at some point so I just removed the merge commit.