[MU4 Task] New dialogs for corruption warnings

[bkunda]

Task description This task would resolve the issues in #11807

There are two variations of the same dialog to be implemented.

1. When the user attempts to open a corrupted file, and the file can still be opened

2. When the user attempts to open a corrupted file, and the file cannot be opened

(In this case, Get help redirect to the musescore.org support forum).

Full UX specification has been sent to @RomanPudashkin for implementation

@Tantacrul @oktophonie @abariska FYI

[eitanmuir]

Noting that in Windows 10 there is no option to Show Details - please add this feature too as restarting a whole score is a bit of a headache!

[cbjeukendrup]

@bkunda One thought about this design: it feels a little bit random to me that this dialog mentions musescore.com. The fact that uploading might not work properly is just one small aspect. Something like the following would be more complete and informative:

File "The_Avengers_Theme_Song_full_orchestra.mscz" is corrupted and may contain errors

This can cause MuseScore to malfunction and might lead to crashes.

(You can probably find a nicer wording for this.)

If we really want, we could add "In particular, saving to musescore.com may fail unless these errors are resolved."

[sam-the-programmer]

We need a show details feature on Musescore 4 when a file is corrupted.

[cbjeukendrup]

@bkunda One thought about this design: it feels a little bit random to me that this dialog mentions musescore.com. The fact that uploading might not work properly is just one small aspect. Something like the following would be more complete and informative:

File "The_Avengers_Theme_Song_full_orchestra.mscz" is corrupted and may contain errors This can cause MuseScore to malfunction and might lead to crashes.

(You can probably find a nicer wording for this.)

If we really want, we could add "In particular, saving to musescore.com may fail unless these errors are resolved."

@bkunda Friendly bump on this comment :)

[bkunda]

Thanks @cbjeukendrup, this makes perfect sense. I'll amend the mockups now.

[bkunda]

I've updated the messaging of the first dialog in the issue description: basically, I've shortened the header text by removing the reference to "errors", and have put this instead in the body text. I think it's wise to not limit the scope of potential "malfunctions", and I also don't think it's necessary to alarm the user too much by mentioning crashes. Also, the detail about "saving to musescore.com" can, I think, safely be covered within the scope of "...could cause MuseScore to malfunction". Thanks, as always, for your input on this @cbjeukendrup!

[cbjeukendrup]

That looks good to me!

Actually I had one more thought: instead of "may contain errors" we can just say "contains errors". That's simply the definition of being corrupted, so there's no uncertainty. That's a bit of a nitpick though, so not sure if it's worth the efforts of rendering the mockups yet again...

And then I have an unimportant cosmetic suggestion for the "Error details have been copied to the clipboard" message: instead of showing yet another popup, we could show it a bit more subtly next to the button itself. Here's a very quick and rough mockup:

[RobFog]

Yeah, would be nice to avoid the popup.

[bkunda]

I cannot disagree with any of your suggestions @cbjeukendrup 🙂

[bkunda]

@cbjeukendrup Issue description updated accordingly. Will send and @RomanPudashkin link to Figma files separately.

[cbjeukendrup]

@RomanPudashkin Please let me know if you are working on this or if you would like me to do it in a follow-up PR :)