MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard
verified publisher icon musescore

[MU4 Issue] MuseScore gives me the finger when I undo deleting letters

Open HemantAntony opened this issue 3 years ago • 9 comments

Describe the bug After deleting letters in a dynamics and undoing, I get a finger

To Reproduce Steps to reproduce the behavior:

  1. Create a dynamics text (like ppp)
  2. Double click to go into edit mode
  3. Delete a letter
  4. Undo

Expected behavior MuseScore should not give me the finger

Screenshots Issue.webm

Platform information

  • OS: Ubuntu 22.04 LTS

@Tantacrul FYI

HemantAntony avatar Dec 14 '22 16:12 HemantAntony

Best issue title ever.

its-not-nice avatar Dec 14 '22 17:12 its-not-nice

Can't reproduce on Ubuntu 20.06 @DmitryArefiev could you check. As I know you also have Ubuntu 22

abariska avatar Dec 15 '22 14:12 abariska

I can reproduce on Ubuntu Studio 22.04

sammik avatar Dec 15 '22 16:12 sammik

Can't reproduce on Ubuntu 20.06 @DmitryArefiev could you check. As I know you also have Ubuntu 22

Yes, I can repro on my Ubuntu 22.04.01.

And it really gives the finger))))

Screenshot from 2022-12-15 19-19-13

DmitryArefiev avatar Dec 15 '22 17:12 DmitryArefiev

Also happens in MU3.

And not only in dynamics, but in any text, if You "insert special characters" -> "musical symbols" and than remove symbol and want undo, it doesnt bring back removed symbol, but replaces it by some other non musical symbol.

sammik avatar Dec 15 '22 18:12 sammik

I'm working on this. Hope I can create a PR soon 🤞🏾

HemantAntony avatar Dec 20 '22 16:12 HemantAntony

👉

abariska avatar Dec 20 '22 17:12 abariska

@abariska @DmitryArefiev I have a PR for this issue #15529. But it reverts a change made by @wizofaus in his PR #8815. Since its a large PR, I'm not sure why he would add this change

Also @sammik My PR should solve the bug you mentioned

HemantAntony avatar Dec 23 '22 09:12 HemantAntony

@abariska @DmitryArefiev I have a PR for this issue #15529. But it reverts a change made by @wizofaus in his PR #8815. Since its a large PR, I'm not sure why he would add this change

Also @sammik My PR should solve the bug you mentioned

@HemantAntony I checked #15170 briefly on #15529, it seems to be fine. But it also should be reviewed before full testing. Which probably will happen after New Years holidays..

Thank you!

DmitryArefiev avatar Dec 26 '22 14:12 DmitryArefiev

Fixed in #15529

DmitryArefiev avatar May 12 '23 13:05 DmitryArefiev

I will miss this issue 😄

abariska avatar May 12 '23 14:05 abariska

You're not alone 😁. Will remember this issue. Its my 100th merged PR :)

HemantAntony avatar May 12 '23 15:05 HemantAntony

Congrats!

Let us remember this issue by holding up our glasses. We wish you well!

Tantacrul avatar May 12 '23 15:05 Tantacrul

Apparently a similar issue with 3.x, not a finger but a wrongly styled dynamics glyph

Jojo-Schmitz avatar May 15 '23 11:05 Jojo-Schmitz