MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard

Fix #14567: Add 7, 8, 9 to Guitar string numbers in palettes

Open HemantAntony opened this issue 3 years ago • 4 comments

Resolves: #14567

  • [x] I signed CLA
  • [x] I made sure the code in the PR follows the coding rules
  • [x] I made sure the code compiles on my machine
  • [x] I made sure there are no unnecessary changes in the code
  • [x] I made sure the title of the PR reflects the core meaning of the issue you are solving
  • [x] I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • [x] I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [ ] I created the test (mtest, vtest, script test) to verify the changes I made

HemantAntony avatar Dec 02 '22 13:12 HemantAntony

@HemantAntony Hi! I've just tried to test this PR, but couldn't open the build. It crashes during opening Could you take a look? It's on macOS 12.6 Monterey, macbook Air M1

abariska avatar Dec 12 '22 14:12 abariska

I just tried this on Win 11 and it also crashes on startup (after the splash screen). The Linux build works fine for me, still, though!

its-not-nice avatar Dec 12 '22 14:12 its-not-nice

@HemantAntony A simple rebase should do the job here; it's probably because of the incompatibility between older master builds and the latest Muse Sampler.

cbjeukendrup avatar Dec 12 '22 14:12 cbjeukendrup

@abariska Can you try again?

HemantAntony avatar Dec 23 '22 16:12 HemantAntony

@HemantAntony please rebase it

RomanPudashkin avatar Mar 01 '23 18:03 RomanPudashkin

@RomanPudashkin rebased

HemantAntony avatar Mar 04 '23 04:03 HemantAntony