MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard

[MU4] Fix GH#14787: Finale Maestro / Broadway: repeat dots appear too low

Open Jojo-Schmitz opened this issue 1 year ago • 9 comments

Resolves: #14787

Jojo-Schmitz avatar Nov 28 '22 10:11 Jojo-Schmitz

Might be easier and shorter to check for Emmentaler, Gonville and MuseJazz? (I'll do this in a 2nd commit, once the GitHub checks completed) (Edit: done; don't get confused by the red x, all tests passed!)

Or, as these are 'our' fonts', to fix those? (That'd be beyond my paygrade though)

Jojo-Schmitz avatar Nov 28 '22 10:11 Jojo-Schmitz

That alternative fix would turn the issue into (a workaround for) "Emmentaler, Gonville, MuseJazz: repeat dots appear too high"

Jojo-Schmitz avatar Nov 28 '22 11:11 Jojo-Schmitz

Or, as these are 'our' fonts', to fix those?

@oktophonie What do you think about this? Can we reasonably easily fix those fonts themselves?

cbjeukendrup avatar Nov 28 '22 13:11 cbjeukendrup

@cbjeukendrup which version do you want, the 1st commit or the result of a squash with the 2nd?

Jojo-Schmitz avatar Nov 28 '22 13:11 Jojo-Schmitz

I like the latter!

cbjeukendrup avatar Nov 28 '22 13:11 cbjeukendrup

I can fix Emmentaler, Gonville and MuseJazz. I may not be able to do it for a few days so perhaps we may need this hack instead.

Tantacrul avatar Nov 28 '22 17:11 Tantacrul

That hack is in already, I just corrected it to also work for Finale Maestro and Finale Broadway, by simply inverting it.

Jojo-Schmitz avatar Nov 28 '22 17:11 Jojo-Schmitz

@Tantacrul @oktophonie What do you think about merging this for now, and then fixing "our" three fonts later when we have more time, so that we can remove the workaround by that time?

cbjeukendrup avatar Dec 02 '22 11:12 cbjeukendrup

That's indeed the whole and only purpose of this PR ;-) (now knowing what the real culprit is)

Jojo-Schmitz avatar Dec 02 '22 11:12 Jojo-Schmitz

Came up again in https://musescore.org/en/node/343759 Can we have this for 4.0.2 too, please?

Jojo-Schmitz avatar Jan 29 '23 13:01 Jojo-Schmitz

I've nominated the linked issue for 4.0.2.

cbjeukendrup avatar Jan 29 '23 14:01 cbjeukendrup

Ah, the issue, not the PR, I see now, thanks and sorry for the noise

Jojo-Schmitz avatar Jan 29 '23 14:01 Jojo-Schmitz