MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard

[MU4 Issue] Preferences > Shortcuts > Define shortcut: fields for Old/New shortcut not aligned

Open cbjeukendrup opened this issue 3 years ago • 5 comments

In the "Define shortcut" dialog, found in Preferences > Shortcuts, the fields for the Old and New shortcut are not aligned.

It's especially visible in the Dutch translation at the moment:

Scherm­afbeelding 2022-11-23 om 19 05 11

(Aside: that translation is incorrect; the word "Sneltoetscombinatie" is a contamination of "Sneltoets" and "Toetscombinatie". I've already fixed it on Transifex.)

Expected behaviour It would be visually more pleasant if the two fields were aligned, i.e. their left sides are at the same horizontal position.

The left-alignment of the text labels should stay as it is.

Additional context This can be solved pretty easily by using a QML GridLayout instead of two RowLayouts.

cbjeukendrup avatar Nov 23 '22 18:11 cbjeukendrup

Hey @cbjeukendrup can I work on this issue ?

vaibhavrawat24 avatar Nov 29 '22 08:11 vaibhavrawat24

Yes, you're welcome!

cbjeukendrup avatar Nov 29 '22 11:11 cbjeukendrup

thank you @cbjeukendrup for assigning me the issue, I've cloned the repo and read the readme file since I'm new to this repo can you please guide me through.

vaibhavrawat24 avatar Nov 30 '22 10:11 vaibhavrawat24

I would suggest you start reading here: https://github.com/musescore/MuseScore/wiki/Set-up-developer-environment It is a complete guide for how to compile the code and set up your IDE for editing it.

cbjeukendrup avatar Nov 30 '22 12:11 cbjeukendrup

@bkunda Could you please check the linked PR to see if you like the change? (#15491)

cbjeukendrup avatar Dec 24 '22 00:12 cbjeukendrup