MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard

[MU4 Issue] A4 scores created in MU3 get imported as Letter

Open MarcSabatella opened this issue 2 years ago • 6 comments

Describe the bug Scores created in MU3 that use the default page size of A4 get converted to Letter on import into MU4

To Reproduce Steps to reproduce the behavior:

  1. In MU3, create a score that uses the default page size of A4
  2. Load that score into MU4
  3. Go to Format / Page Settings
  4. See error: page size is now Letter

Expected behavior Page size should remain A4

Platform information

  • OS: Linux

Additional context The problem is that the legacy 302 style defaults file is wrong - it has letter as the page size. The height/width/printablewidth settings need to be fixed.

Note the problem is only visible for scores that truly use the built-in default A4 settings. If your system currently defaults to Letter in MU3 (because of the printer check, or because you have a custom default style set in preferences) and manually set the page size to A4 - or if you change the page size to something else then back to A4 - then the problem might not occur. That's because MU3 might see the page size as not being exactly equal to A4 due to round-off, and thus, the modified page size is written to the file. Whereas on systems where A4 is the true default and you leave the page size alone, the page size does not normally get written.

MarcSabatella avatar Nov 17 '22 14:11 MarcSabatella

@oktophonie

Tantacrul avatar Nov 22 '22 15:11 Tantacrul

FWIW, I originally pinged @cbjeukendrup to see if he wanted to add this simple fix (just updated the style file as noted above) to his PR https://github.com/musescore/MuseScore/pull/14561. Otherwise, I can do a separate PR for this

MarcSabatella avatar Nov 22 '22 17:11 MarcSabatella

OK, good to know! I'll let @cbjeukendrup comment on this.

Tantacrul avatar Nov 22 '22 17:11 Tantacrul

@MarcSabatella If you have a potential solution, feel free to make a PR for it. I don't have much time for coding the next few days. Also, as a small separate PR, it may be merged sooner than as part of a large-ish PR.

cbjeukendrup avatar Nov 22 '22 18:11 cbjeukendrup

PR submitted, see note in PR comment about how to test.

MarcSabatella avatar Nov 23 '22 13:11 MarcSabatella

I had forgotten about this after https://github.com/musescore/MuseScore/pull/14561 was merged, but this bug still exists and was just reported by a user today. I believe my PR is still valid.

MarcSabatella avatar Jan 05 '23 16:01 MarcSabatella

Yet another showstopper (for me, We,,, OK, relative easy to workaround, once you know), fix should really make it into 4.0.2

Jojo-Schmitz avatar Jan 16 '23 12:01 Jojo-Schmitz