MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard

[MU4 Task] Link "Watch video" button in all "Style Improvements" dialogs to new engraving video

Open bkunda opened this issue 1 year ago • 2 comments

Task description The "Watch video" button in all "Style Improvements" dialogs should point to this video on the MuseScore YouTube channel: https://youtu.be/U7dagae87eM

Screenshot 2022-09-21 at 4 24 35 pm Screenshot 2022-09-21 at 4 28 42 pm

Note: these dialogs (and any other associated dialogs with alternate messaging referring to earlier versions of MuseScore) are triggered by opening a score created with MuseScore 3.6 or earlier in MuseScore 4.0.

@HemantAntony Wondering if you might be up for this one? 🙂 Let us know if you can help!

Thanks!

bkunda avatar Sep 21 '22 14:09 bkunda

Seems easy enough! Happy to do it :)

HemantAntony avatar Sep 21 '22 14:09 HemantAntony

Seems easy enough! Happy to do it :)

Thank you so much 🙏🏻

bkunda avatar Sep 21 '22 14:09 bkunda

@bkunda Currently in the code there is a check if the person is from China, if so another link is used (https://www.bilibili.com/video/BV1FT4y1K7UM). This is likely because Youtube is blocked in China

HemantAntony avatar Sep 25 '22 08:09 HemantAntony

@bkunda Anyhow I have a create a PR #13484

Also, I couldn't test it because neither the new nor old video links open. I tried copying the link of a random youtube video and pasting, but that didn't work. I think Youtube is having a problem

HemantAntony avatar Sep 25 '22 08:09 HemantAntony

IIRC YouTube is not really blocked in China, but nobody really uses it. For that reason, @Howard-C re-uploaded the video (with Chinese captions "burned in", IIRC) to Bilibili which is the Chinese equivalent to YouTube.

@Howard-C, would you like to do that again for this new video? You should probably work with @Tantacrul and/or @bkunda, because there are certainly more YouTube videos that are linked from MuseScore 4 (most notably, the "Learn" page is full of them!).

@HemantAntony Until the new video is uploaded to Bilibili, I suggest we just use the YouTube version. I think linking to an old video is worse than linking to the new video on a sub-optimal platform.

cbjeukendrup avatar Sep 25 '22 12:09 cbjeukendrup

@cbjeukendrup agreed

Tantacrul avatar Sep 25 '22 15:09 Tantacrul

Okay, updated the PR :)

HemantAntony avatar Sep 26 '22 07:09 HemantAntony

Howard-C, would you like to do that again for this new video? You should probably work with Tantacrul and/or bkunda, because there are certainly more YouTube videos that are linked from MuseScore 4 (most notably, the "Learn" page is full of them!).

Hi @cbjeukendrup, sorry for the delay in response as I'm not often checking GitHub these days, but thanks for the invite! I'd really much like to do it. Also @Tantacrul I just saw the video list you posted in Discord, could you perhaps point out how many of them are to be linked from musescore.org and/or MuseScore itself? If it's all of them, then I'll do all of them, no probs, but I can't guarantee I can finish them before the final release.

Harmoniker1 avatar Oct 08 '22 17:10 Harmoniker1

All the videos I linked on Discord are intended to be accessed from within MuseScore 4 too.

Thanks!

Tantacrul avatar Oct 08 '22 17:10 Tantacrul

OK then! By the way, Bilibili doesn't seem to have an unlisted option, so if we intend to get the links to Bilibili videos to include in the release, they would have to be uploaded and be seen by the public in advance. Is this OK?

Harmoniker1 avatar Oct 08 '22 17:10 Harmoniker1