MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard

Fix #10451: Improvements to Layout Palette

Open HemantAntony opened this issue 2 years ago • 8 comments

Resolves: #10451

  • [x] I signed CLA
  • [x] I made sure the code in the PR follows the coding rules
  • [x] I made sure the code compiles on my machine
  • [x] I made sure there are no unnecessary changes in the code
  • [x] I made sure the title of the PR reflects the core meaning of the issue you are solving
  • [x] I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • [x] I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [ ] I created the test (mtest, vtest, script test) to verify the changes I made

HemantAntony avatar Aug 15 '22 12:08 HemantAntony

I think the new Without Qt test fail is not related to this PR

HemantAntony avatar Aug 15 '22 13:08 HemantAntony

I think the new Without Qt test fail is not related to this PR

Problem with #include "ui/iuiconfiguration.h" into engraving module, better use IEngravingConfiguration, add proxy method

igorkorsukov avatar Aug 15 '22 13:08 igorkorsukov

🟢 Tested on Windows and MacOS @igorkorsukov I'm happy with this if you think it's okay to merge. Thank you @HemantAntony!

bkunda avatar Sep 02 '22 14:09 bkunda

@HemantAntony sorry I've just found one more thing from #10451 before @igorkorsukov can merge it:

  1. Replace current tooltip for "Group measures" with "Keep measures on the same system"

Are you still available to address this?

bkunda avatar Sep 05 '22 10:09 bkunda

@bkunda I have updated the PR. I forgot about that part :)

HemantAntony avatar Sep 05 '22 15:09 HemantAntony

@bkunda I have updated the PR. I forgot about that part :)

Thanks @HemantAntony.

@igorkorsukov good to merge from my end. Over to you.

bkunda avatar Sep 06 '22 14:09 bkunda

Rebase needed

cbjeukendrup avatar Sep 18 '22 12:09 cbjeukendrup

done :)

HemantAntony avatar Sep 18 '22 12:09 HemantAntony