MuseScore icon indicating copy to clipboard operation
MuseScore copied to clipboard

Published 20 hours ago • verified publisher icon musescore

[MU4] Fix musescore#12028: Fix messaging when opening non-existing scores

Open iwoithe opened this issue 3 years ago • 2 comments

Resolves: #12028

  • [x] I signed CLA
  • [x] I made sure the code in the PR follows the coding rules
  • [x] I made sure the code compiles on my machine
  • [ ] I made sure there are no unnecessary changes in the code
  • [x] I made sure the title of the PR reflects the core meaning of the issue you are solving
  • [x] I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • [x] I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [ ] I created the test (mtest, vtest, script test) to verify the changes I made

iwoithe avatar Jun 27 '22 06:06 iwoithe

Rebase needed :)

cbjeukendrup avatar Sep 26 '22 21:09 cbjeukendrup

Done. :slightly_smiling_face:

iwoithe avatar Sep 27 '22 12:09 iwoithe

@igorkorsukov can you please review this?

bkunda avatar May 10 '23 13:05 bkunda

@iwoithe sorry but can you please rebase this again? We will look at it asap!

bkunda avatar May 10 '23 13:05 bkunda

@iwoithe can I just make a small request for an amendment in this PR? When the file is not corrupted, but simply cannot be found, can we show this dialog instead? Screenshot_2023-05-22_at_5 23 27_pm It just doesn't make sense to call a corruption dialog when there is no corruption. Thanks! @DmitryArefiev FYI

bkunda avatar May 23 '23 15:05 bkunda

@bkunda Actually that would defeat the purpose of this PR: the point of this PR is to be a bit more specific than "an error had occurred". Would it be an idea to maintain the specific-ness of this PR? So, if a file cannot be opened...

  • ... if it's because of corruption, show the corruption dialog
  • ... otherwise, show that simple dialog you propose, but with the more specific explanation implemented by this PR. Of course, the exact wordings of these explanations can be discussed.

cbjeukendrup avatar May 23 '23 21:05 cbjeukendrup

@cbjeukendrup can you please follow up on this one? Many thanks!

bkunda avatar Jun 14 '23 13:06 bkunda

@iwoithe I created a follow-up PR with some additional changes here: https://github.com/musescore/MuseScore/pull/18376 That PR contains your PR, so I will close this one, but you can consider it merged. Thanks for the contribution!

cbjeukendrup avatar Jul 04 '23 16:07 cbjeukendrup