[MU4 Issue] "Reset preferences" doesn't reset all preferences (e.g. advanced), no confirmation

[wizofaus]

Describe the bug The "reset preferences" doesn't appear to reset all preferences, e.g. any voice colours, despite giving no indication that it shouldn't apply to all preferences. In fact it appears it requires closing and reopening the dialog to see that it has actually taken effect. Further, there's no confirmation before doing this operation, which is not undoable, potentially meaning preferences that have required some time to get right could be lost easily.

To Reproduce Steps to reproduce the behavior:

1. Go to Preferences|Advanced and choose a difference color for voice1 (or any setting here)
2. Click OK
3. Go back to Preferences|Advanced and click "Reset preferences"
4. Colours do not reset
5. Click OK
6. Again open Preferences|Advanced and observed that colors are now reset

Expected behavior On clicking "Reset preferences" I'd like to have a confirmation dialog confirming I really do want to lose all my custom preferences, and on confirming would expect all preferences that can be set in this dialog to be reset and the dialog refreshed to show factory-default values.

Screenshots If applicable, add screenshots to help explain your problem.

Platform information

• OS: [e.g. macOS, Windows, Linux]

Additional context It seems there are some settings that DO refresh immediately to the factory defaults, though I haven't quite figured out what the logic is yet.

[Tantacrul]

Agree:

1. Preferences should show all reset values (eg. in advanced) without the dialog needing to be closed and reopened.
2. A confirmation dialog should be shown when a person chooses to reset all preferences. Are you sure you want to reset preferences? This action cannot be undone. [Cancel] [Reset]

(no need for a 'don't ask me again' tickbox in this case. It's better to always ask)