[MU4 Issue] Instrument name does not update in parts dialog and its tab on replace

[HemantAntony]

(Updated by @Tantacrul, @DmitryArefiev ) Describe the bug When opening some older scores, the 'Replace Instrument' feature does not work. However, it does work for new scores.

BUG№1 - FIXED in #13097 To Reproduce:

1. Open string quartet 2.zip
2. Open Violin I part
3. Go to score and replace the Violin I with another instrument, like a Flute, using the Instruments panel
4. Observe that the instrument label in score/mixer and sounds do not update.

https://user-images.githubusercontent.com/90187801/190918230-036284c9-7ec6-4971-9e1f-ade697bb5a60.mp4

BUG№2 (STILL OCCURS) To Reproduce:

1. Open string quartet 2.zip
2. Open Violin I part
3. Go to score and replace the Violin I with another instrument, like a Flute, using the Instruments panel
4. Observe that the instrument name in part, in its tab and in parts dialog do not update.

https://user-images.githubusercontent.com/90187801/190918628-ed607a95-dde3-4545-a3eb-344fb7ff3031.mp4

Expected behavior The instrument's name should be updated in the parts dialog and its tab

Initial video from bug report

https://user-images.githubusercontent.com/88136054/146490932-a6ced8f6-6d20-4c0c-9d38-c2142dcf0a55.mp4

Desktop (please complete the following information): Win, Mac, Linux

[HemantAntony]

I am working on this

[Tantacrul]

I'm going to alter the description a little and escalate this. The issue is fixed for new scores. However, I have an older score where this doesn't work.

[Tantacrul]

I don't know how widespread this problem is anymore. It could just be an issue with my file, which was originally a MusicXML import into 3.6. Other comments welcome!

[HemantAntony]

I can still reproduce this in a similar way to my original example

Also if unclear, I'm no longer working on this. 5 months is too long :)

[Tantacrul]

OK, I've moved it to alpha then if you are still experiencing it.

[DmitryArefiev]

@RomanPudashkin Says there are two different issues here:

• one about not updating sounds/name in Mixer
• and another about not updating instrument name in part, in parts dialog and in part's tab

The issue №1 is fixed in #13097 The issue №2 still happens

I've edited the description to separate two issues

[DmitryArefiev]

@Tantacrul I moving this to Beta2 since the issue with changing sound and the name in Mixer is fixed now.

And also this issue is similar to #13239

[Tantacrul]

@DmitryArefiev - agreed.

[woooowoooo]

An interesting thing to note is that on other parts the name is updated, but not on the original. The name change shown here is from Trumpet 4 to Trumpet 3 (and the deletion of the old Trumpet 3). This is an issue for instrument name changes too, not just actual instrument changes. Edit: And the (old) Trumpet in B♭ 3 part is not shown here because I closed it; otherwise it is still an empty part that still exists (and shouldn't!), just like in #13239

[DmitryArefiev]

Fixed in #14288