INAGAKI Hiroshi

Results 41 comments of INAGAKI Hiroshi

First of all, please don't close existing PR when you update commit(s). https://openwrt.org/docs/guide-developer/frequent-pr-mistakes#do_not_multi-post_or_re-post_prs And, please use your real name for Signed-off-by and author field in the commit. https://openwrt.org/submitting-patches#submission_guidelines

> Signed-off-by: gl-yangweiping [[email protected]](mailto:[email protected]) Is ```gl-``` really part of your real name? If not, please remove it. And insert a space between your first and last name.

Please update author field (```From: ```) in the [commit](https://patch-diff.githubusercontent.com/raw/openwrt/openwrt/pull/10778.patch) to have the same name as ```Signed-off-by: ```. current: ```From: gl-yangweiping ``` ``` git commit --amend --author="Weiping Yang " git push...

Please insert a space after the colon of the prefix in the commit title. ```ipq40xx: add support for GL.iNet GL-A1300```

Thank you for the testing! > I'm seeing a few build failures on zyxel_gs1900-* and allnet_all-sg8208m if I enable luci and kernel dymanic debug: Hmm, I tried to build with...

Sorry for late response, I was busy... OK, I'll update the PR.

Note: I intentionally made small commits. It's to make it easier to replace or rearrange later, and as I commented in the PR comment at the first, I'll squash some...

UPDATE: - check mask of bridge flags - cleanup enable_learning/flood - drop workaround of l2 learning Note: Changes that overlap with other PRs were temporarily left.

Note: GPL of XGS1210 - from ```dal_maple_l2_portLimitLerningCntAction_get``` in *sdk/src/dal/maple/dal_maple_l2.c* ``` /* translate register value to action */ switch (act) { case LIMIT_LEARN_CNT_ACTION_DROP: *pAction = 1; break; case LIMIT_LEARN_CNT_ACTION_FORWARD: *pAction =...

UPDATE: - rebase on current master - cleanup enable_learning/flood for rtl839x Tested on Panasonic Switch-M48eG PN28480K (RTL8393M), ping to other device on LAN from switch and accessing to LuCI from...