Michael Lumish

Results 374 comments of Michael Lumish

I think it could also be that a `.js` extension will work everywhere. I would want to get a better understanding of the practical consequences of these import statement variations...

If this happens with Node's http2 module without any involvement of gRPC, then it seems like the issue is more suited to the Node repository than to this one.

When I run that same command with the same version of grpc-tools in the `examples` directory of this repository (only adjusting the output directory to `./helloworld/static_codegen/`), I get the expected...

It usually should detect if a connection is dropped, but sometimes it just doesn't happen. I recommend enabling keepalives using the channel options `grpc.keepalive_time_ms` (controls how often pings are sent)...

That looks like a good idea to me, but it's not clear to me how async resources should be integrated into the existing code.

If I understand correctly, that's not enough to have the call's handler run in the `grpc` async scope, which I think would be desirable. I would also want to address...

From reading the [current documentation](https://nodejs.org/api/async_context.html) it seems like properly integrating with that API is more involved than just creating an `AsyncResource` object and calling `emitDestroy`

Well, the search directories are expected to be relative to the current directory. What if the `--skip` directories were also relative to the current directory? Then there wouldn't be any...

The log shows the same error I saw: "unsupported certificate purpose". I think the problem is that there is something about the certificate that Node's TLS library can't handle. gRPC...