musicbrainz-userscripts icon indicating copy to clipboard operation
musicbrainz-userscripts copied to clipboard

Use absolute URLs in @require statements

Open zas opened this issue 1 year ago • 1 comments

  • relative links do not always work (we had multiple reports about this)

See https://github.com/murdos/musicbrainz-userscripts/pull/542 and https://github.com/murdos/musicbrainz-userscripts/issues/579

zas avatar Oct 17 '24 13:10 zas

Hmm, using absolute URLs breaks installations from branches other than master and for forks, so I am generally not a fan of that.

Yes, I agree with that too. But we had issues in the past and they continue, and scripts break everytime :(

Not really happy with this PR either :( but not sure what to do.

zas avatar Oct 17 '24 15:10 zas

Issue will be solved by packing userscripts with rollup. See https://github.com/murdos/musicbrainz-userscripts/pull/709

murdos avatar Oct 21 '25 17:10 murdos