musicbrainz-userscripts icon indicating copy to clipboard operation
musicbrainz-userscripts copied to clipboard

Display shortcut for relationships should also optionally display `discography entries`

Open vzell opened this issue 2 years ago • 1 comments

My use case is to display discography entries on the release pages for Bruce Springsteen releases. I managed to get it working with the following patch

modified   mb_relationship_shortcuts.user.js
@@ -33,6 +33,7 @@ const urlRelationsIconClasses = {
     secondhandsongs: 'secondhandsongs',
     vgmdb: 'vgmdb',
     wikidata: 'wikidata',
+    'discography entry': 'discographyentry',
 };
 
 const otherDatabasesIconClasses = {
@@ -94,6 +95,10 @@ td.relationships span.favicon.ended {
     background-image: url(https://www.hdtracks.com/favicon.ico);
     background-size: 16px;
 }
+.discographyentry-favicon {
+    background-image: url(https://www.springsteenlyrics.com/favicon.ico);
+    background-size: 16px;
+}
 .creativecommons-favicon {
     background-image: url(https://creativecommons.org/favicon.ico);
 }

The problem is it displays the same icon for all discography entries as can be seen in the following screenshot for the release-group https://musicbrainz.org/release-group/1503429e-e48d-4386-a70a-3b2e4195f276

image

Screenshot from the corresponding release https://musicbrainz.org/release/a831423d-f9c9-4744-9ca5-91cc5ae5b31f

image

Would it be possible to read the favicon.ico Files directly from the right discography entry URL instead of hardcoding one ?

vzell avatar Jan 09 '22 15:01 vzell

The favicons in the release sidebar are loaded by @jesus2099's mb_ALL-LINKS.user.js, so it should be possible to write similar code for the shortcut icon userscript.

kellnerd avatar Feb 06 '22 09:02 kellnerd