musicbrainz-userscripts
musicbrainz-userscripts copied to clipboard
murdos
discogs_importer: subtracks in Discogs to separete tracks in Musicbrainz
Hi I modified Discogs importer to generate separate tracks for Discogs subtracks instead of merging them to one track in musicbrainz. The track format will be "trackname: subtrackname" which would match the classical music guideline.
Hello @hirokobayashi, But MusicBrainz is supposed to represent the CD faithfully, without adding fictitious tracks, isn't it?
Hello @hirokobayashi, But MusicBrainz is supposed to represent the CD faithfully, without adding fictitious tracks, isn't it?
This commit fixes #138
Please check the discogs document about track and heading here. https://support.discogs.com/hc/en-us/articles/360005055373-Database-Guidelines-12-Tracklisting#Index_Tracks_And_Headings
Original discogs importer uses a heading as a track and subsequent tracks are merged into the heading.
Oh thanks, in fact you already found a doc about the distinction between indeed tracks (that are 1 CD track) and headings (CD track set, logical group of several CD tracks).
I would like to test your patch with the two cases and come back here afterwards. ☺️
Pinging @jesus2099 @murdos @Schweinepriester @kellnerd
I'm happy to rebase this if someone will commit to merging it in the next week.
I've fixed this for classical albums in a really hacked together fork here: https://github.com/kaysond/musicbrainz-userscripts/blob/discogs-classical/discogs_importer.user.js
Oh, is that patch to old now? I think Discogs had recently changed their pages.
Sorry @hirokobayashi, only now I took time to test it:
I first tested this 2CD release from this post . It works good with latest version of the script, splitting it in 2 mediums. But this PR patched script does not load at all on the Discogs page.
@kaysond, is that what you meant by rebasing? Redo this patch but in the latest importer version?
Next tests will be this single track with indexes release from this other post.
Wow! It seems better!
| Discogs release | Current importer | @hirokobayashi + @kaysond version |
|---|---|---|
| 2017-02-19: trackset | 🔴 | 🟢 |
| 2017-02-21: strange LP bugged tracklist | what is expected? | different, I find it better, but what is expected? |
| 2017-02-21: multi disc tracksets | 🔴 | 🟢 |
| 2020-05-10: single split track | 🔴 | 🟢 |
| 2020-06-06: complex multi-disc tracksets | 🔴 | 🟢 |
| 2020-12-17: A/B LP | 🟢 | 🟢 |
| 2020-12-17: CD+CD+DVD | 🔴 | 🔴 |
| 2020-12-27: A/B+C/D with bad? subtracks | 🔴 | 🔴 |
| 2020-12-27: A/B+C/D with good? subtracks | 🔴 | 🔴 |
| 2020-12-27: split track on second CD | 🔴 | 🔴 |
(I will update this table with more tests)
Wow, it must be so difficult to manage all the cases.
@jesus2099 - correct. This PR is based on a very old discogs import script. Mine was based on the latest one, but its not very good code!