musicbrainz-userscripts icon indicating copy to clipboard operation
musicbrainz-userscripts copied to clipboard

Discogs importer doesn't show up on Firefox

Open ewauq opened this issue 7 years ago • 7 comments
trafficstars

Since a recent Firefox update, the Discogs importer doesn't seem to work anymore. On Chrome everything is ok.

There is no error on the FF console. The version used on both browsers is 2017.02.25.0.

image

image

ewauq avatar Jan 05 '18 10:01 ewauq

Probably related to #159

murdos avatar Jan 06 '18 21:01 murdos

I'm having a similar issue with the buttons showing up in Firefox (and Chrome).

Firefox console shows:

Source map error: Error: NetworkError when attempting to fetch resource. Resource URL: moz-extension://<UID>/%20Import%20Discogs%20releases%20to%20MusicBrainz.user.js#15 Source Map URL: jquery.min.map

Same thing with the Bandcamp script:

Source map error: Error: NetworkError when attempting to fetch resource. Resource URL: moz-extension://<UID>/%20Import%20Bandcamp%20releases%20to%20MusicBrainz.user.js#16 Source Map URL: jquery.min.map

I also launched a clean Windows Sandbox with Chrome installed and had similar source map errors. It didn't matter what extension was used (tried Violentmonkey and Tampermonkey).

Might have something to do with stuff I found while looking around:

  • https://github.com/webpack/webpack/issues/1194

Possible workaround I haven't tried yet:

https://github.com/webpack/webpack/issues/1194#issuecomment-402494524

Core issue seems to lead all the way back to:

WebExtensions Doesn't Find Source Maps https://bugzilla.mozilla.org/show_bug.cgi?id=1437937

TFWol avatar Aug 08 '21 23:08 TFWol

@thefinalwolf Discogs changed the layout of their release pages ago, maybe this caused your problem:

  • Issue: #411
  • Fix: #412

kellnerd avatar Aug 14 '21 19:08 kellnerd

@kellnerd It's possible; I'm not familiar with JavaScript and have only created a few scripts (through lots of trial and error) for sites that bugged me. I don't see errors specific to not being able to find elements though.

I'll try a few tests once I can allocate time.

TFWol avatar Aug 16 '21 19:08 TFWol

@thefinalwolf You don't need to have a look at the code changes, all I wanted to say is that your problem might not be the one in this issue but the other one which has already been fixed. So you would only need to update the userscript and see if the import button shows up again.

kellnerd avatar Aug 17 '21 08:08 kellnerd

@kellnerd Ah, I see. Yup, replacing the script with the one from #412 worked just fine. Same network error, but doesn't matter since I could still import.

Thanks for pointing this out. I wonder why this fix hasn't been merged into the main branch.

Maybe I was looking at the wrong branch. I don't GitHub much.

TFWol avatar Aug 17 '21 11:08 TFWol

Never mind, it was a recent commit I didn't notice 7 days ago. Sweet.

TFWol avatar Aug 17 '21 11:08 TFWol

Six year old ticket, no longer actionable. Please file a new issue for problems with the latest userscript version if necessary.

kellnerd avatar Jan 17 '24 00:01 kellnerd