letsrate icon indicating copy to clipboard operation
letsrate copied to clipboard

Published 20 hours ago • verified publisher icon muratguzel

Refactor letsrate model to fix rating on inherited models

Open 3den opened this issue 11 years ago • 5 comments

This PR is need to fix a problem on on the rating cache that was saving the wrong cacheable_type for models. I also cleaned up the code to make it easier to understand. Please merge this for the next version.

3den avatar Jan 09 '14 23:01 3den

@muratguzel please merge this PR so I can use the oficial version. Thanks for publishing this gem I really liked it.

3den avatar Jan 09 '14 23:01 3den

@muratguzel btw why do you use travis if you have no tests?

3den avatar Jan 10 '14 00:01 3den

I will add tests :) But yes you are right. And also I will check and merge you commit. Thanks

muratguzel avatar Jan 21 '14 08:01 muratguzel

Thanks @muratguzel :)

3den avatar Jan 21 '14 08:01 3den

hi all! i was wondering, is this still valid for merging?

berkos avatar Jun 10 '14 17:06 berkos