Would love color coding

[easycheese]

For example,

Green highlighting (on right side) if item is added Red highlighting (on left side) if item is removed Orange(?) highlighting on both sides if item is modified

[mupchrch]

This package already does the green/red highlighting. The sides for the colors can be swapped via the package settings. Orange highlighting is used to show you what diff chunk you are selected on if you use the commands "Split Diff: Next Diff" and "Split Diff: Prev Diff".

I can look into highlighting a different color for modified chunks, but I'd want more people to weigh in on this before I just changed functionality.

[easycheese]

I think you misunderstood. Right now, with color diff, the left side is always green (or red).

Existing:
Item added        Left: Red     Right: Green
Item Removed      Left: Red     Right Green
Item Modified     Left: Red     Right Green

Proposed
Item added        Left: Green    Right: Green
Item Removed      Left: Red      Right Red
Item Modified     Left: Orange   Right Orange

The actual colors utilized doesn't matter. This mirrors functionality available in other editors and allows the user to see at a glance, what changes have been made vs just knowing that changes have been made

[mupchrch]

Ah, thank you for clarifying. However, I am still a little confused about one more detail. How do you identify whether something was added vs removed?

Maybe you could point me in the direction of other editors that show how this is done? Thanks!

[easycheese]

I've never used a differential tool that doesn't have this capability...

On Wed, Nov 2, 2016, 16:31 laurenblackfox [email protected] wrote:

I think he's misunderstanding the function of diff. Diff only highlights the difference between two files (or states of files), it doesn't make the determination of whether or not something was added or removed, since that's subjective. Diff only shows that there is a difference between two states.

I can't think of any other diff tool that makes this distinction off the top of my head.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mupchrch/split-diff/issues/59#issuecomment-258005255, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgeUFwIdqSVKCfGlo8jYW1r83G9hF26ks5q6QEQgaJpZM4IozcL .

[stormwulfren]

@easycheese I retracted my statement - after reflection, I could in fact think of a couple diff tools I've used that did do this. Kompare being the one that comes to mind.

[easycheese]

Fair enough :)

On Wed, Nov 2, 2016, 16:43 laurenblackfox [email protected] wrote:

@easycheese https://github.com/easycheese I retracted my statement - after reflection, I could in fact think of a couple diff tools I've used that did do this. Kompare being the one that comes to mind.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/mupchrch/split-diff/issues/59#issuecomment-258008297, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgeUJVIIqK8QRKWGs2Djobh3WarFxegks5q6QQRgaJpZM4IozcL .

[piyushkhemka]

Would it be possible to let the user choose the colors? I am using a light theme and the red makes it impossible to read. I would prefer a lighter shade of red while someone else using a dark theme might want a darker shade. Let the user choose?

Currently, the settings option only allows me to select between green and red.

[mupchrch]

@piyushkhemka There is currently an issue for this - #78. There is some info I just posted on styling the colors from your user stylesheet there, hopefully that is useful!