munus icon indicating copy to clipboard operation
munus copied to clipboard
verified publisher icon munusphp

[Q] Remove matchValue()

Open mtk3d opened this issue 2 years ago • 2 comments

As I can see, the minimum version of PHP for latest Munus version is going to be 8.0 now https://github.com/munusphp/munus/commit/610f2c618dd7855548044447ebf93f975d7d28c0. I can't see any reason to keep Munus's matchValue() now. PHP 8.0 has native match that works better in most cases in my opinion. I think it can be removed. What do you think about it?

mtk3d avatar Feb 19 '23 21:02 mtk3d

This is your code :D, can stay, can be removed, both options are ok with me :wink:

akondas avatar Feb 20 '23 13:02 akondas

I think I will remove match, I want to raise phpstan level and there is a lot of code to change which will not bring much value since PHP 8 has native match anyway and munus is no longer supporting php 7.4. Are we fine with that?

akondas avatar Jun 02 '24 08:06 akondas