woonki

Results 208 comments of woonki

Yes, this issue is gone with v4 ```js function Underscore(props) { return React.createElement("div", undefined, props.foo__one, props.foo__two); } ```

I have no opinion. Actually, not sure what we should test for the binding module. One thing that came to my mind is to test the generated js output, maybe?

Can you elaborate on your intention with an example? What prop do you want to add? Anyway, with V10.*, the new `JsxDOM` module is opt-in, so you can do something...

The generated js representation should be ```js var make = getErrorBoundary(React.Component); ``` But, by using jsx ppx ```js function RescriptReactErrorBoundary(Props) { return getErrorBoundary(React.Component); } var make = RescriptReactErrorBoundary; ```

~~I found one solution to make the ErrorBoundary component works by using jsx ppx. By using the jsx ppx in normal way, the generated js output is inevitable.~~ ```rescript function...

I fixed the runtime error of ErrorBoundary. It enables us to use `@react.component` without needing external binding to the ErrorBoundary component in javascript.

> Need someone to double-check, or are you confident that it's right and can be merged? I'm confident that it fixes the runtime error caused by #47

I'm also trying to build ppx.exe but no gain. Looking forward to any tip.

@somebody1234 yes, it does. The vscode extension for OCaml does binding with jsoo. https://github.com/ocamllabs/vscode-ocaml-platform/tree/master/src-bindings

@fhammerschmidt @zth I guess the binding is not that huge amount of job maybe. I think that ReScript's interop system is quite productive and flexible. I just came up the...