woonki

Fixed the installation error with npm https://github.com/mattdamon108/react-jsx-ppx-v4/commit/01720fe5dd3b82ac69c7e9ae90d87c00fba704d1 after fixing the rescript version https://github.com/rescript-lang/rescript-react/pull/49/commits/9ac34b0ee02a0e3598826229741fb01a3812ad7c The reason was rescript-react#jsx PR has an unavailable dependency.

> @mattdamon108 now I'm wondering: should rescript-react move inside the compiler? It seems to be tightly coupled with the JSX, and tight coupling at a distance is a recipe for...

> The alternative is to provide a compatibility module ReactV3. > So one can take an existing v3 app and build it with the new rescript-react and version:3 as long...

Regarding PR to remove the key from the props type https://github.com/rescript-lang/syntax/pull/635, I've added the `addKeyProp` into `React.res` and tested in my example project, it seems fine. ```rescript // original //...

> How about adding instead `Jsx.addKeyProp` so it stays with the compiler? So one can mostly test V4 without updating rescript-react, as long as only basic features are used. Very...

`Jsx.addKeyProp` https://github.com/rescript-lang/rescript-compiler/pull/5664

> @mattdamon108 how does that ^ backwards compatibility experience sound like? Sounds very promising. Sorry for being late to make `React.V3` module. It is a simple task. I'll make it...

It is more tricky than I expected. 😄 https://github.com/rescript-lang/rescript-react/pull/49/commits/86401bcb5bb5b60d13c685a787af78bdbe996e4b I couldn't put it inside `React.res` due to circular referencing.

> Would you be able to try a big project, see if everything still builds (and generated identical JS) with V3 compatibility? > > I think the bsconfig option is:...

> Would you be able to try a big project, see if everything still builds (and generated identical JS) with V3 compatibility? I've ran on my company project, face this...