woonki
woonki
One solution #53
Side comment: I verified that V4 & Jsx don't break my test project having dependencies of V3 modules. So, I tried to run the battle-test of V10 & V4 &...
> > Side comment: I verified that V4 & Jsx don't break my test project having dependencies of V3 modules. So, I tried to run the battle-test of V10 &...
I totally agree on the comment from @ryyppy https://github.com/rescript-lang/rescript-compiler/pull/5484#discussion_r910144004 Here is my thought for the future plan. What do you think? 1. Remove `Jsx` from rescript-react. If the namespace `Jsx`...
The breaking change is introduced by merging `RescriptReact.res` into `React.res`. Side comment: I realized why some of react component binding was not written with `@react.component`. Simply it is not possible,...
> How does one test this? Perhaps one way is to create a separate sample project, which installs the compiler from master, and the rescript-react from this PR, and tests...
> > > How does one test this? Perhaps one way is to create a separate sample project, which installs the compiler from master, and the rescript-react from this PR,...
Here is the example project for test https://github.com/mattdamon108/react-jsx-ppx-v4 * ReScript compiler@master * rescript-react@jsx (this PR branch)
> `npm install` failed for me but `yarn` worked (after waiting a while). Oh, didn't notice. I'll check the installation with npm.