woonki

Results 208 comments of woonki

One thing that came to my mind is to check if the user tries to use async with jsx definition as below. I'll make a PR if there is something...

@cristianoc I found one thing left to be done. This PR needs to be done https://github.com/rescript-lang/rescript-react/pull/49 which contains the new jsx transform api bindings. The ppx v4 is using it.

> That is with automatic mode right? Yes, correct.

> > That is with automatic mode right? > > Yes, correct. One more thing, https://github.com/rescript-lang/rescript-react/blob/8f31f375bc8965dad4a1c498b6ab69227f150069/src/RescriptReact.res#L1 `RescriptReact` module needs to be introduced with `jsxConfig({version:r 4})` even though without automatic mode....

I can summarize this PR https://github.com/rescript-lang/rescript-react/pull/49 into three things to achieve. 1. For V4 + classic There are react components that are not defined with `@react.component` in the current `React.res`....

Oh, I meant v0.10.3 is the current version of rescript-react. There's no need to make a new version for V3. Sorry for making a confusion.

> @mattdamon108 so I think next steps are publishing a new beta version of rescript-react, finish up any testing and documentation, then invite people to test V4 in its various...

If you agree to make the breaking version for JSX V4, then I'll fix the PR https://github.com/rescript-lang/rescript-react/pull/49 accordingly.

AFAIK, the `import()` should have a string arg which is the js module path. The example intends `@import` or `import` to transform the `Widget.make` to the component's path as a...

```rescript module DynamicWidget = { open Next.Dynamic @react.component(dynamic) let make = dynamic(() => import(Widget.make), { ssr: false }) } // generated to module DynamicWidget = { open Next.Dynamic type props...