munin icon indicating copy to clipboard operation
munin copied to clipboard

Published 20 hours ago • verified publisher icon munin-monitoring

[munin-run] cleanup

Open cgzones opened this issue 6 years ago • 8 comments

  • format with perltidy
  • fix some perlciritc warnings

cgzones avatar Aug 27 '18 11:08 cgzones

Pull Request Test Coverage Report for Build 2428

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 62.424%
Files with Coverage Reduction New Missed Lines %
lib/Munin/Master/UpdateWorker.pm 5 77.37%
<!-- Total: 5
Totals Coverage Status
Change from base Build 2425: -0.3%
Covered Lines: 1020
Relevant Lines: 1634
💛 - Coveralls

coveralls avatar Aug 27 '18 11:08 coveralls

There's a lot of whitespace changes here...

steveschnepp avatar Aug 27 '18 13:08 steveschnepp

I split it up

cgzones avatar Aug 27 '18 14:08 cgzones

dropped perltidy changes

cgzones avatar Aug 29 '18 11:08 cgzones

ping

cgzones avatar Sep 21 '18 11:09 cgzones

@steveschnepp: what do you think about the remaining changes?

sumpfralle avatar Nov 14 '18 00:11 sumpfralle

@steveschnepp: the rest looks OK to me. Should we merge it?

sumpfralle avatar Jan 09 '19 20:01 sumpfralle

@steveschnepp: there are only a few lines of changes left in the discussion. Should we merge these?

sumpfralle avatar Mar 20 '20 02:03 sumpfralle